Bug 1944522 - Add Content-Type header option in Harbormaster HTTP Build step #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
globau
changed the title
La0
force-pushed
the
json-content-type
branch
from
87cbbcd to
c6c977f
Compare
Author
|
I rebased on top of #47 to get a CircleCI run |
La0
force-pushed
the
json-content-type
branch
from
c6c977f to
d7536d6
Compare
dklawren
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug 1944522
This PR adds an option to the Harbormaster HTTP Build Step to send an extra
Content-Typeheader.The current behaviour is preserved by default: no
Content-Typeheader is sent.I was able to test these changes locally, querying my own machine through a public IP from the docker container.
Using a debug server, I logged the headers sent by Phabricator when triggering manually a build plan: